Skip to content

Commit

Permalink
Fix to call didFinishCommand (#6757)
Browse files Browse the repository at this point in the history
When `XCBuildDelegate` receives a `taskComplete` message, it calls
`buildSystem(:didStartCommand:)` of `BuildSystemDelegate`.
However, it should probably call `buildSystem(:didFinishCommand:)`.

Since there doesn't seem to be any concrete type conforming to
`BuildSystemDelegate`, this change doesn't appear to have any impact on
the behavior of existing code.
  • Loading branch information
omochi committed Oct 4, 2023
1 parent 1c917e0 commit 95d0160
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Sources/XCBuildSupport/XCBuildDelegate.swift
Expand Up @@ -81,7 +81,7 @@ extension XCBuildDelegate: XCBuildOutputParserDelegate {
}
case .taskComplete(let info):
queue.async {
self.buildSystem.delegate?.buildSystem(self.buildSystem, didStartCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue))
self.buildSystem.delegate?.buildSystem(self.buildSystem, didFinishCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue))
}
case .buildDiagnostic(let info):
queue.async {
Expand Down

0 comments on commit 95d0160

Please sign in to comment.