Fix to call didFinishCommand
#6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
tomerd
reviewed
Jul 31, 2023
| @@ -81,7 +81,7 @@ extension XCBuildDelegate: XCBuildOutputParserDelegate { | |||
| } | |||
| case .taskComplete(let info): | |||
| queue.async { | |||
| self.buildSystem.delegate?.buildSystem(self.buildSystem, didStartCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue)) | |||
| self.buildSystem.delegate?.buildSystem(self.buildSystem, didFinishCommand: BuildSystemCommand(name: "\(info.taskID)", description: info.result.rawValue)) | |||
There was a problem hiding this comment.
@neonichu @abertelrud this seems correct on the surface, but not sure if there are some subtleties that required this less-intuitive usage
There was a problem hiding this comment.
I wonder if this is because of how SwiftPM's logging works? Since we do log in didStartCommand, maybe this was done to "fix" the log output when using XCBuild.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci please test |
|
@swift-ci please test windows |
neonichu
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
XCBuildDelegatereceives ataskCompletemessage, it callsbuildSystem(:didStartCommand:)ofBuildSystemDelegate.However, it should probably call
buildSystem(:didFinishCommand:).Since there doesn't seem to be any concrete type conforming to
BuildSystemDelegate, this change doesn't appear to have any impact on the behavior of existing code.