Improve `Destination.sdkPlatformFrameworkPaths()` #5876

neonichu · 2022-11-04T01:29:30Z

We should not ignore errors or an empty SDK platform path since that means XCTest imports and test execution might silently fail on macOS with no indication to what the problem is.

neonichu · 2022-11-04T01:29:46Z

@swift-ci please smoke test

neonichu · 2022-11-04T01:57:57Z

Linux self-hosted is failing with

<EXPR>:0: error: TestDiscoveryTests.testSubclassedTestClassTests : threw error "terminated(1): /home/build-user/swiftpm/.build/x86_64-unknown-linux-gnu/debug/swift-test --package-path /tmp/Miscellaneous_TestDiscovery_Subclass.1HY8Nx/Miscellaneous_TestDiscovery_Subclass --configuration debug output:
    /tmp/Miscellaneous_TestDiscovery_Subclass.1HY8Nx/Miscellaneous_TestDiscovery_Subclass/.build/x86_64-unknown-linux-gnu/debug/SubclassPackageTests.xctest: error while loading shared libraries: libswift_RegexParser.so: cannot open shared object file: No such file or directory

which seems like a broken toolchain potentially?

Windows is failing somewhere early in the process as well.

neonichu · 2022-11-04T02:42:51Z

@swift-ci please smoke test

neonichu · 2022-11-04T04:41:27Z

@swift-ci please smoke test

neonichu · 2022-11-04T06:00:56Z

@swift-ci please smoke test

MaxDesiatov · 2022-11-04T11:35:24Z

@swift-ci please smoke test macOS

neonichu · 2022-11-04T16:33:20Z

@swift-ci please smoke test

neonichu · 2022-11-04T17:45:47Z

Of course things are passing after adding extra logging 🥲

neonichu · 2022-11-04T17:45:53Z

@swift-ci please smoke test macOS

neonichu · 2022-11-04T19:49:53Z

[error]: Invalid manifest
/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/spm-tests-testSimpleAPI.qYJkUF/MyPkg/Package.swift:4:8: error: no such module 'PackageDescription'
import PackageDescription
       ^

Hm, not sure why we aren't seeing the new compilerCommandLine stuff I added.

neonichu · 2022-11-04T20:02:13Z

Hm, not sure why we aren't seeing the new compilerCommandLine stuff I added.

Ah, it is being set in the wrong place.

neonichu · 2022-11-04T20:03:53Z

@swift-ci please smoke test

neonichu · 2022-11-04T20:30:46Z

@swift-ci please smoke test

neonichu · 2022-11-04T22:17:36Z

Seems reasonable that this fails? We're looking for the PD libs in the installation directory before installing.

[error]: Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsoverlay", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/TemporaryDirectory.dHFMod/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx10.15", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-F", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks", "-I", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "5", "-I", "/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-package-description-version", "5.7.0", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/spm-tests-testSimpleAPI.MrySgk/MyPkg/Package.swift", "-o", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/TemporaryDirectory.tJZRZ9/mypkg-manifest"])
/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/spm-tests-testSimpleAPI.MrySgk/MyPkg/Package.swift:4:8: error: no such module 'PackageDescription'
import PackageDescription
       ^

Not sure what changed to make us to do that.

neonichu · 2022-11-04T22:19:38Z

Probably we're ending up in the fallback case, instead of the testing case here:

// this tests if we are debugging / testing SwiftPM with SwiftPM
        if localFileSystem.exists(applicationPath.appending(component: "swift-package")) {
            return .init(
                manifestLibraryPath: applicationPath,
                pluginLibraryPath: applicationPath
            )
        }

        // we are using a SwiftPM outside a toolchain, use the compiler path to compute the location
        return .init(swiftCompilerPath: swiftCompilerPath)

neonichu · 2022-11-04T22:40:25Z

Not sure I understand how this ever works? applicationPath will be /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Xcode/Agents/xctest so we'll always use search paths relative to swiftCompilerPath when running a test that doesn't shell out.

neonichu · 2022-11-04T22:49:09Z

Oh I see, this is why we're setting up a bit of a fake toolchain as part of bootstrap, so I think the issue is that we're directly pointing to the installed swiftc rather than to the symlink in the fake toolchain. I think what broke things is #4213, because with that we're using the installed swiftc directly.

neonichu · 2022-11-04T22:49:51Z

@swift-ci please smoke test

neonichu · 2022-12-01T19:18:47Z

Dropped add36ce now, let's see if that brings back the issue.

neonichu · 2022-12-01T19:18:58Z

@swift-ci please smoke test

neonichu · 2022-12-01T20:47:38Z

This macOS failure looks unrelated:

/Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/swift-driver/Sources/SwiftDriver/Jobs/Planning.swift:200:31: error: variable binding in a condition requires an initializer\n    guard let dependencyGraph else {\n                              ^\nninja: build stopped: subcommand failed.\n'
Ninja invocation failed:

neonichu · 2022-12-01T20:49:25Z

@swift-ci please smoke test macOS

neonichu · 2022-12-02T00:09:45Z

[951/1087] Compiling SwiftDriver GeneratePCHJob.swift
/Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/checkouts/swift-driver/Sources/SwiftDriver/Jobs/Planning.swift:200:31: error: variable binding in a condition requires an initializer
    guard let dependencyGraph else {
                              ^

Hmmm, not sure what this is about -- @artemcm any ideas?

artemcm · 2022-12-02T00:11:22Z

@swift-ci please smoke test macOS

artemcm · 2022-12-02T00:11:43Z

[951/1087] Compiling SwiftDriver GeneratePCHJob.swift
/Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/checkouts/swift-driver/Sources/SwiftDriver/Jobs/Planning.swift:200:31: error: variable binding in a condition requires an initializer
    guard let dependencyGraph else {
                              ^

Hmmm, not sure what this is about -- @artemcm any ideas?

My bad. Fixed this here: apple/swift-driver#1233.

neonichu · 2022-12-02T01:46:57Z

@swift-ci please smoke test macOS

neonichu · 2022-12-02T21:24:37Z

@swift-ci please smoke test macOS

neonichu · 2022-12-05T17:42:46Z

@swift-ci please smoke test macOS

neonichu · 2022-12-05T17:43:22Z

3 successful runs so far, I think we should do ~10 before making any further determination.

neonichu · 2022-12-05T19:19:07Z

@swift-ci please smoke test macOS

neonichu · 2022-12-05T22:01:05Z

@swift-ci please smoke test macOS

neonichu · 2022-12-06T06:15:36Z

@swift-ci please smoke test macOS

neonichu · 2022-12-06T18:41:02Z

@swift-ci please smoke test macOS

neonichu · 2022-12-06T20:24:37Z

@swift-ci please smoke test macOS

neonichu · 2022-12-07T00:26:48Z

@swift-ci please smoke test macOS

neonichu · 2022-12-07T23:22:28Z

We are at 9 runs, so one more. Since we haven't seen the error again, it seems like it was stemming from some underlying tools failure rather than anything in SwiftPM itself.

neonichu · 2022-12-07T23:23:53Z

@swift-ci please smoke test macOS

neonichu · 2022-12-08T06:21:51Z

OK, this passed again. This should be sufficient signal to reenable the disabled tests. There's also a fix in here for one test which we need to bring in, as well as some other changes we should land. I'm going to split this PR into a couple individual changes.

We should not ignore errors or an empty SDK platform path since that means XCTest imports and test execution might silently fail on macOS with no indication to what the problem is.

neonichu · 2022-12-08T06:39:57Z

Updating this PR to only change Destination.sdkPlatformFrameworkPaths()

neonichu · 2022-12-08T06:40:15Z

@swift-ci please smoke test

neonichu · 2022-12-08T06:45:58Z

Created #5958 and #5957 for the other changes that were previously part of this PR.

neonichu self-assigned this Nov 4, 2022

neonichu requested review from abertelrud, tomerd and elsh as code owners November 4, 2022 01:29

neonichu mentioned this pull request Nov 4, 2022

Disable FunctionalTests temporarily #5875

Merged

tomerd approved these changes Nov 4, 2022

View reviewed changes

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 6d50e07 to 2812780 Compare November 4, 2022 02:42

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 2812780 to 6ccd668 Compare November 4, 2022 04:41

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 6ccd668 to fa2a1d4 Compare November 4, 2022 05:59

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from fa2a1d4 to 42b8295 Compare November 4, 2022 16:33

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 42b8295 to 98e5054 Compare November 4, 2022 20:03

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 98e5054 to b3f3f0b Compare November 4, 2022 20:30

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from add36ce to 81f89da Compare December 1, 2022 19:18

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from 81f89da to ffa2225 Compare December 7, 2022 23:23

Improve Destination.sdkPlatformFrameworkPaths()

46bf794

We should not ignore errors or an empty SDK platform path since that means XCTest imports and test execution might silently fail on macOS with no indication to what the problem is.

neonichu force-pushed the improve-sdkPlatformFrameworkPaths branch from ffa2225 to 46bf794 Compare December 8, 2022 06:39

neonichu marked this pull request as ready for review December 8, 2022 06:40

neonichu merged commit b268125 into main Dec 8, 2022

neonichu deleted the improve-sdkPlatformFrameworkPaths branch December 8, 2022 08:12

Improve Destination.sdkPlatformFrameworkPaths() #5876

Improve Destination.sdkPlatformFrameworkPaths() #5876

Conversation

neonichu commented Nov 4, 2022 • edited

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

MaxDesiatov commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Nov 4, 2022

neonichu commented Dec 1, 2022

neonichu commented Dec 1, 2022

neonichu commented Dec 1, 2022

neonichu commented Dec 1, 2022

neonichu commented Dec 2, 2022

artemcm commented Dec 2, 2022

artemcm commented Dec 2, 2022

neonichu commented Dec 2, 2022

neonichu commented Dec 2, 2022

neonichu commented Dec 5, 2022

neonichu commented Dec 5, 2022

neonichu commented Dec 5, 2022

neonichu commented Dec 5, 2022

neonichu commented Dec 6, 2022

neonichu commented Dec 6, 2022

neonichu commented Dec 6, 2022

neonichu commented Dec 7, 2022

neonichu commented Dec 7, 2022

neonichu commented Dec 7, 2022

neonichu commented Dec 8, 2022

neonichu commented Dec 8, 2022

neonichu commented Dec 8, 2022

neonichu commented Dec 8, 2022

Improve `Destination.sdkPlatformFrameworkPaths()` #5876

Improve `Destination.sdkPlatformFrameworkPaths()` #5876

neonichu commented Nov 4, 2022 •

edited