New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further API breakages in 1.10.0 #1025
Comments
I'll get to this later today. re validation script - if there is one we can use, please open an issue with details so we can track setting that up. clearly something we should do. 😄 |
Sure, filed #1026. |
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this issue
Jul 10, 2020
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this issue
Jul 10, 2020
thomasvl
added a commit
that referenced
this issue
Jul 10, 2020
Tagged and CocoaPods pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sorry folks, my issue yesterday (#1022) failed to catch the full suite of breakages we accidentally shipped in 1.10.0. I missed this at the time, but when we went to update another project we caught some more.
I finally decided to run SwiftNIO's
check_no_api_breakages
script, comparing 1.9.0 and 1.10.1. This is what else slipped through:This points out that we need the same patch as #1023 but for returning
.array(fromJSONString:options:)
and.array(fromJSONUTF8Data:options)
. This will require a 1.10.2.Sorry about not running the full validation earlier. Perhaps we should consider integrating a variant of NIO's script to CI?
The text was updated successfully, but these errors were encountered: