5.9 sendable issues for the 1.x branch #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Sep 20, 2023
Bring over SwiftNIO's `UnsafeMutableTransferBox` to manage `knownTypes` and avoid the Swift 5.9 warnings about `Sendable`. Longer term, it might make sense have something like NIO's `LockedValueBox` or just move all this management to a Task.
thomasvl
force-pushed
the
5_9_sendable_issues_1_x_branch
branch
from
da13f6f
to
00648f8
Compare
|
Added guards to the Sendable bits. |
FranzBusch
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick over all the fixes, odds are we'll want to do a release soonish so no one can get these warnings on the 1.x branch either.