Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.9 sendable issues for the 1.x branch #1463

Merged
merged 3 commits into from
Sep 20, 2023
Merged

5.9 sendable issues for the 1.x branch #1463

merged 3 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Move from a var to a let to help silence some 5.9 Sendable warnings.

    @thomasvl
    thomasvl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e24baac View commit details
    Browse the repository at this point in the history

  2. Change the test error to a struct to avoid Sendable issues with 5.9.

    @thomasvl
    thomasvl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3fb9b42 View commit details
    Browse the repository at this point in the history

  3. Bring over UnsafeMutableTransferBox to knownTypes 

    Bring over SwiftNIO's `UnsafeMutableTransferBox` to manage `knownTypes` and
avoid the Swift 5.9 warnings about `Sendable`.

Longer term, it might make sense have something like NIO's `LockedValueBox`
or just move all this management to a Task.
    @thomasvl
    thomasvl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    00648f8 View commit details
    Browse the repository at this point in the history