Support "-nan" in TextFormat. #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As odd as it sounds, upstream supports this and there is a unittest that ensure it parses: https://github.com/protocolbuffers/protobuf/blob/3c03e9351c57081d0dffae120ed37497017f105c/src/google/protobuf/compiler/parser_unittest.cc#L464 It seems to have come from: protocolbuffers/protobuf#15017 So make sure Swift is also able to parse it. Also reflow some of the unknown field parsing as inf/nan don't need to be special cased with how the flow now works.
allevato
approved these changes
May 9, 2024
tbkka
reviewed
May 9, 2024
tbkka
reviewed
May 9, 2024
tbkka
reviewed
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As odd as it sounds, upstream supports this and there is a unittest that ensure it parses:
https://github.com/protocolbuffers/protobuf/blob/3c03e9351c57081d0dffae120ed37497017f105c/src/google/protobuf/compiler/parser_unittest.cc#L464
It seems to have come from:
protocolbuffers/protobuf#15017
So make sure Swift is also able to parse it.
Also reflow some of the unknown field parsing as inf/nan don't need to be special cased with how the flow now works.