Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "-nan" in TextFormat. #1651

Merged
merged 1 commit into from
May 9, 2024
Merged

Support "-nan" in TextFormat. #1651

merged 1 commit into from
May 9, 2024

Commits on May 9, 2024

  1. Support "-nan" in TextFormat. 

    As odd as it sounds, upstream supports this and there is a unittest that
ensure it parses:

  https://github.com/protocolbuffers/protobuf/blob/3c03e9351c57081d0dffae120ed37497017f105c/src/google/protobuf/compiler/parser_unittest.cc#L464

It seems to have come from:

  protocolbuffers/protobuf#15017

So make sure Swift is also able to parse it.

Also reflow some of the unknown field parsing as inf/nan don't need to be
special cased with how the flow now works.
    @thomasvl
    thomasvl committed May 9, 2024
    Configuration menu
    Copy the full SHA
    142f16f View commit details
    Browse the repository at this point in the history