Hashing updates #747
Merged
Hashing updates #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we only mix the fieldNumber once for these fields instead of once per entry. The extra data into the hash doesn't really buy us anything, and just slows down hash performance.
Conditional conformance on the containers now make them Hashable if they value type is hashable. Use this instead of manually doing the hashing of the values in the containers to get any standard library improvements. https://swift.org/blog/conditional-conformance/ documents this as Swift 4.1, but there seem to have been issues, as it fails until Swift 4.2.
allevato
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.