Change package to ServiceContext; keep baggage compat module #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
approved these changes
May 26, 2023
stevapple
reviewed
May 26, 2023
ktoso
force-pushed
the
wip-service-context
branch
from
44e9b12
to
8c150fd
Compare
ktoso
force-pushed
the
wip-service-context
branch
from
85881a5
to
a3c4e7b
Compare
ktoso
force-pushed
the
wip-service-context
branch
from
a3c4e7b
to
db72a40
Compare
|
And we're green -- and deprecated the Baggage names as well already. |
|
@weissi signed off via chat 👍 |
|
@ktoso do we need to rename the repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31
We are going to make a big rename here.
Due to many teams actively using this type in production right now even, and sometimes OUTSIDE of the context of distributed tracing just as a "glorified type-safe typesafe dictionary" we are going to embrace that that's what this type is, and going to call it ServiceContext.
Truth be told, this type wanted to be called this long time ago but it was back then decided that Context was too generic and we picked a tracing only name. Reality has shown us that the type is much more useful and we should not limit its wording and usage to tracing.
Thanks for opening the discussion and I'll do the necessary changes including repo name change.