Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Factor a couple more universal inits into _Pointer #17952

Merged
merged 1 commit into from Jul 15, 2018

Conversation

airspeedswift
Copy link
Member

All pointers can be created from an UnsafeMutablePointer, so those can move to _Pointer

@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift
Copy link
Member Author

@atrick one side effect of this is that it's stomped on some of the notes we produce to nudge people towards using .assumingMemoryBound(to:). Do you see those as just supporting the transition back in Swift 3? Or more a forever-important note?

@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@airspeedswift airspeedswift merged commit a8328a8 into apple:master Jul 15, 2018
@lilyball
Copy link
Collaborator

I think this PR needs to be reverted (except I guess for the seemingly-unrelated @inlinable tweaks in BridgeObjectiveC.swift). This introduces initializers on UnsafePointer and UnsafeMutablePointer that don't belong (see SR-9800 for details).

Also it looks like you forgot to remove these initializers from UnsafeMutableRawPointer, that still redeclares these initializers.

@atrick
Copy link
Member

atrick commented Feb 3, 2019

Wow, huge thanks to @lilyball for pointing out a problem that I incredibly overlooked before it became a really big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants