New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoDiff] Fix differentiation crashes related to definite initialization. #32031
Conversation
@gottesmm: would you like to sanity check this PR? It should not be controversial. |
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: [dynamic_lifetime]
, not [dynamic_replacement]
.
alloc_stack [dynamic_replacement]
attribute cloning.alloc_stack [dynamic_lifetime]
attribute cloning.
de31fab
to
8563a3a
Compare
@swift-ci Please test |
Build failed |
Build failed |
8563a3a
to
6f5d4cc
Compare
@swift-ci Please test |
Build failed |
Build failed |
alloc_stack [dynamic_lifetime]
attribute cloning.
@swift-ci Please test |
Build failed |
Build failed |
@swift-ci Please test |
Build failed |
Unrelated llvm macOS CI error. |
Build failed |
Linux CI appears to have flaked while building SwiftPM. |
Build failed |
Build failed |
Linux and macOS platform tests have both flaked multiple times. I'll try smoke tests instead. |
@swift-ci Please smoke test |
1017baa
to
a27860a
Compare
@swift-ci Please smoke test |
Make `SILCloner:visitAllocStack` correctly propagate the `[dynamic_lifetime]` attribute. Resolves SR-12886: differentiation transform error related to the `VJPEmitter` subclass of `SILCloner`.
Fix SIL locations and debug scopes in `VJPEmitter` for: - Pullback struct `struct` instructions - Predecessor enums `enum` instructions These instructions are not directly cloned from the original function and should have auto-generated locations. Resolves SR-12887: debug scope error for `VJPEmitter`-generated function.
58717e4
to
ff97ae7
Compare
@swift-ci Please smoke test Linux |
[SIL] Fix
alloc_stack [dynamic_lifetime]
attribute cloning.Make
SILCloner:visitAllocStack
correctly propagate the[dynamic_lifetime]
attribute.Resolves SR-12886: differentiation transform error related to the
VJPEmitter
subclass of
SILCloner
.[AutoDiff] Fix SIL locations and debug scopes.
Fix SIL locations and debug scopes in
VJPEmitter
for:struct
instructionsenum
instructionsThese instructions are not directly cloned from the original function and should
have auto-generated locations.
Resolves SR-12887: debug scope error for
VJPEmitter
-generated functions.