Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoDiff] Fix differentiation crashes related to definite initialization. #32031

Merged
merged 2 commits into from
May 29, 2020
Merged

[AutoDiff] Fix differentiation crashes related to definite initialization. #32031

merged 2 commits into from
May 29, 2020

Commits on May 29, 2020

  1. [SIL] Fix alloc_stack [dynamic_lifetime] attribute cloning. 

    Make `SILCloner:visitAllocStack` correctly propagate the `[dynamic_lifetime]`
attribute.

Resolves SR-12886: differentiation transform error related to the `VJPEmitter`
subclass of `SILCloner`.
    @dan-zheng
    dan-zheng committed May 29, 2020
    Configuration menu
    Copy the full SHA
    56c8eba View commit details
    Browse the repository at this point in the history

  2. [AutoDiff] Fix SIL locations and debug scopes. 

    Fix SIL locations and debug scopes in `VJPEmitter` for:
- Pullback struct `struct` instructions
- Predecessor enums `enum` instructions

These instructions are not directly cloned from the original function and should
have auto-generated locations.

Resolves SR-12887: debug scope error for `VJPEmitter`-generated function.
    @dan-zheng
    dan-zheng committed May 29, 2020
    Configuration menu
    Copy the full SHA
    ff97ae7 View commit details
    Browse the repository at this point in the history