Change error diagnosed for when self isn't available in scope
#59140
Conversation
…tests to reflect change
|
@AnthonyLatsis test? |
|
@swift-ci please test |
|
@hamishknight Fixed compilation errors, try to test it again, also, every test file should have |
Yup, every test that needs to run a typecheck over the test file |
Co-authored-by: Hamish Knight <hamish_github@mediocremail.com>
…he string to `self` Co-authored-by: Hamish Knight <hamish_github@mediocremail.com>
|
@swift-ci please test |
…e a semicolon instead of a comma
|
@AnthonyLatsis addressed all concerns, could you try test now? |
|
@swift-ci please smoke test |
|
@AnthonyLatsis could you ask it to build a toolchain aswell? The tests pass and everything works but I’m just curious to try out locally |
|
@swift-ci please build toolchain macOS |
|
@xwu Ready for merge now? |
|
@SerenaKit You might want to consider a tailored diagnostic like this for |
|
@swift-ci please test |
|
@SerenaKit I'm going to squash this so that we don't pollute the commit history with review-specific amendments. |
As discussed on https://forums.swift.org/t/changing-error-diagnosed-for-when-self-isn-t-available/57616, the purpose of these changes are to hopefully make it more obvious, especially to beginner programmers, what the purpose of
selfis, as these changes will diagnosecannot findselfin scope, did you mean to declare or extend a typerather than justcannot findselfin scopewhen self isn't available.