Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error diagnosed for when self isn't available in scope #59140

Merged
merged 10 commits into from
Jun 3, 2022
Merged

Change error diagnosed for when self isn't available in scope #59140

merged 10 commits into from
Jun 3, 2022

Commits on May 28, 2022

  1. Diagnose different error for when self cannot be found in scope, add … 

    …tests to reflect change
    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    dbf9927 View commit details
    Browse the repository at this point in the history

  2. add these tests as well

    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    e8f7a4c View commit details
    Browse the repository at this point in the history

  3. De-capatilize the first letter in cannot_find_self_in_scope, rename &… 

    … move test file
    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8082d7e View commit details
    Browse the repository at this point in the history

  4. Fix compilation errors

    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f9f3032 View commit details
    Browse the repository at this point in the history

  5. Use single quoted as suggested by Hamish 

    Co-authored-by: Hamish Knight <hamish_github@mediocremail.com>
    @NSAntoine @hamishknight
    NSAntoine and hamishknight committed May 28, 2022
    Configuration menu
    Copy the full SHA
    1b20d90 View commit details
    Browse the repository at this point in the history

  6. use Name.isSimpleName(Context.Id_self) rather than just comparing t… 

    …he string to `self`

Co-authored-by: Hamish Knight <hamish_github@mediocremail.com>
    @NSAntoine @hamishknight
    NSAntoine and hamishknight committed May 28, 2022
    Configuration menu
    Copy the full SHA
    9e6e0e3 View commit details
    Browse the repository at this point in the history

  7. Update text in test errors to reflect previous changes

    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    721a788 View commit details
    Browse the repository at this point in the history

  8. Remove diagSelfCannotBeFound, reword cannot_find_self_in_scope and us… 

    …e a semicolon instead of a comma
    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f55642f View commit details
    Browse the repository at this point in the history

  9. Change position of comment

    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f1fb67f View commit details
    Browse the repository at this point in the history

  10. within -> in

    @NSAntoine
    NSAntoine committed May 28, 2022
    Configuration menu
    Copy the full SHA
    0bd1e84 View commit details
    Browse the repository at this point in the history