[embedded] In -no-allocations, avoid linking allocating/deallocating runtime functions #70357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
rauhul
reviewed
Dec 10, 2023
include/swift/AST/DiagnosticsSIL.def
Outdated
| ERROR(embedded_swift_allocating_type,none, | ||
| "cannot use allocating type %0 in -no-allocations mode", (Type)) | ||
| ERROR(embedded_swift_allocating,none, | ||
| "cannot use alllocating type in -no-allocations mode", ()) |
There was a problem hiding this comment.
You have an accidental extra "l" in "allocating"
kubamracek
force-pushed
the
embedded-dep-noalloc
branch
from
1e49d16
to
f464471
Compare
|
@swift-ci please test |
kubamracek
force-pushed
the
embedded-dep-noalloc
branch
from
f464471
to
23d6ee7
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In -no-allocations, avoid linking allocating/deallocating runtime functions. Also add an explicit dependency test.