TypeCheckType: Fix some bugs in the any syntax checker
#72659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov and
xedin
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
d0db092
to
4290cea
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
4290cea
to
de2ea64
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
de2ea64
to
56f7e97
Compare
|
@swift-ci please smoke test macOS |
|
@slavapestov @hborla ping |
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
56f7e97
to
6aca4f2
Compare
AnthonyLatsis
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
6aca4f2
to
a01a285
Compare
AnthonyLatsis
commented
Apr 25, 2024
There was a problem hiding this comment.
I have incorporated the tests I deleted here into test/type/explicit_existential.swift and test/type/explicit_existential_swift6.swift
|
@swift-ci please smoke test Linux |
AnthonyLatsis
force-pushed
the
many-any-bugs
branch
from
a01a285
to
be273c3
Compare
AnthonyLatsis
commented
Apr 25, 2024
Comment on lines
-106
to
+108
| // expected-note@-1 2 {{protocol 'CircleMiddle' declared here}} | ||
| protocol CircleStart : CircleEnd { func circle_start() } // expected-error 2 {{protocol 'CircleStart' refines itself}} | ||
| protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 2 {{protocol 'CircleEnd' declared here}} | ||
| // expected-note@-1 3 {{protocol 'CircleMiddle' declared here}} | ||
| protocol CircleStart : CircleEnd { func circle_start() } // expected-error 3 {{protocol 'CircleStart' refines itself}} | ||
| protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 3 {{protocol 'CircleEnd' declared here}} |
There was a problem hiding this comment.
This is unfortunate although definitely not a ExistentialTypeSyntaxChecker problem.
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@swift-ci please smoke test Linux |
|
@swift-ci please test source compatibility release |
|
@hborla ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65026, resolves #65027, resolves #72588.
Diff counts are mostly due to tests.