-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeCheckType: Fix some bugs in the any
syntax checker
#72659
base: main
Are you sure you want to change the base?
Changes from all commits
a02da31
e73d0bb
a33b229
2eb6f40
585eb8c
59717b7
8f6a6d9
6a64cff
be273c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have incorporated the tests I deleted here into |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,9 +103,9 @@ struct DoesNotConform : Up { | |
// Circular protocols | ||
|
||
protocol CircleMiddle : CircleStart { func circle_middle() } | ||
// expected-note@-1 2 {{protocol 'CircleMiddle' declared here}} | ||
protocol CircleStart : CircleEnd { func circle_start() } // expected-error 2 {{protocol 'CircleStart' refines itself}} | ||
protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 2 {{protocol 'CircleEnd' declared here}} | ||
// expected-note@-1 3 {{protocol 'CircleMiddle' declared here}} | ||
protocol CircleStart : CircleEnd { func circle_start() } // expected-error 3 {{protocol 'CircleStart' refines itself}} | ||
protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 3 {{protocol 'CircleEnd' declared here}} | ||
Comment on lines
-106
to
+108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is unfortunate although definitely not a |
||
|
||
protocol CircleEntry : CircleTrivial { } | ||
protocol CircleTrivial : CircleTrivial { } // expected-error {{protocol 'CircleTrivial' refines itself}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to just pass down the outermost location instead of "backtracking" here, but it's fine the way it is