Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SourceKit] Cancel in-flight builds on editor.close #73323

Merged
merged 6 commits into from
May 1, 2024
Merged

[SourceKit] Cancel in-flight builds on editor.close #73323

merged 6 commits into from
May 1, 2024

Commits on Apr 30, 2024

  1. [SourceKit] Ensure ASTCache is guarded by mutex 

    There were a couple of accesses not guarded by
`CacheMtx`, introduce a couple of methods that
guard them, renaming `getASTProducer` while here.

Also make sure we don't ever insert a producer
after it has been purposefully removed by e.g a
close that removes the cached AST.
    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    572fc4e View commit details
    Browse the repository at this point in the history

  2. [test] NFC: Extract out NullEditorConsumer

    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3ec4288 View commit details
    Browse the repository at this point in the history

  3. [test] Switch couple of SourceKit tests to INITIALIZE_LLVM 

    And move this into the constructor since it only
needs doing once.
    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a85be58 View commit details
    Browse the repository at this point in the history

  4. [test] Disable syntax map for NullEditorConsumer 

    This doesn't seem to be required by any of the
tests using it.
    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3fbad90 View commit details
    Browse the repository at this point in the history

  5. [SourceKit] Cancel in-flight builds on editor.close 

    When closing a document, cancel any in-flight
builds happening for it.

rdar://127126348
    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    69f2e26 View commit details
    Browse the repository at this point in the history

  6. [SourceKit] Introduce key for cancelling on close 

    Defaults to `true`.
    @hamishknight
    hamishknight committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    de9806e View commit details
    Browse the repository at this point in the history