[SourceKit] Cancel in-flight builds on editor.close
#73323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham and
rintaro
as code owners
ahoppen
reviewed
Apr 29, 2024
bnbarham
reviewed
Apr 29, 2024
Comment on lines
2462
to
2464
| // Then remove the cached AST if we've been asked to do so. | ||
| if (RemoveCache) | ||
| Removed->removeCachedAST(); |
There was a problem hiding this comment.
Is there any point to not removing from the cache if we never re-use it anyway? Or is there some case where it is re-used?
There was a problem hiding this comment.
I mean we probably ought to re-use if the file contents matches after a close/open, but don't currently. I am planning on putting up a patch for that, but I suppose we could unconditionally remove for the time being.
There were a couple of accesses not guarded by `CacheMtx`, introduce a couple of methods that guard them, renaming `getASTProducer` while here. Also make sure we don't ever insert a producer after it has been purposefully removed by e.g a close that removes the cached AST.
And move this into the constructor since it only needs doing once.
This doesn't seem to be required by any of the tests using it.
When closing a document, cancel any in-flight builds happening for it. rdar://127126348
hamishknight
force-pushed
the
cancel-on-close
branch
from
aaa8fc0
to
e51fac9
Compare
|
After talking with @ahoppen, updated to use an opt-in flag for this behavior |
hamishknight
changed the title
editor.closeeditor.close
Defaults to `true`.
hamishknight
force-pushed
the
cancel-on-close
branch
from
e51fac9
to
de9806e
Compare
|
After further discussion, flipped the default back to |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
hamishknight
changed the title
editor.closeeditor.close
bnbarham
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing a document, cancel any in-flight builds happening for it.
rdar://127126348