[6.0] [SourceKit] Cancel in-flight builds on editor.close
#73375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of accesses not guarded by `CacheMtx`, introduce a couple of methods that guard them, renaming `getASTProducer` while here. Also make sure we don't ever insert a producer after it has been purposefully removed by e.g a close that removes the cached AST.
And move this into the constructor since it only needs doing once.
This doesn't seem to be required by any of the tests using it.
When closing a document, cancel any in-flight builds happening for it. rdar://127126348
Defaults to `true`.
hamishknight
added
🍒 release cherry pick
We need to use a `std::function` here since it escapes the lifetime of the call. rdar://127362231
|
@swift-ci please test |
bnbarham
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of #73323
editor.close.key.cancel_builds: 0if needed.