-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Add Sequence.Element, change ExpressibleByArrayLiteral.Element to ArrayLiteralElement #8990
Conversation
6f4ab28
to
b239a2e
Compare
3b5d6b4
to
d9edefc
Compare
The CSDiag crashers are because the Swift compiler has the name
|
There are other issues in the solver, at least one of which is a |
d9edefc
to
093ab5d
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
Build failed |
CSDiag fix resolved most of the issue but regressed some crashers:
|
The |
7262277
to
0ece9a5
Compare
rdar://problem/32056342 Un-XFAIL compiler crasher regressions |
Build comment file:Optimized (O) Regression (7)
Improvement (7)
No Changes (255)
Regression (6)
Improvement (2)
No Changes (261)
|
0ece9a5
to
11dd5bc
Compare
@swift-ci please test source compatibility |
@swift-ci please benchmark |
Build comment file:Optimized (O) Regression (12)
Improvement (5)
No Changes (252)
Regression (1)
Improvement (3)
No Changes (265)
|
e6197f3
to
19db13c
Compare
3f32603
to
b519b90
Compare
b519b90
to
2a98d61
Compare
@swift-ci please test macOS platform |
2a98d61
to
1455390
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
1455390
to
2b218e6
Compare
@swift-ci please test |
@swift-ci please clean test linux platform |
@swift-ci please clean test macOS platform |
…nt to ArrayLiteralElement (apple#8990) * Give Sequence a top-level Element, constrain Iterator to match * Remove many instances of Iterator. * Fixed various hard-coded tests * XFAIL a few tests that need further investigation * Change assoc type for arrayLiteralConvertible * Mop up remaining "better expressed as a where clause" warnings * Fix UnicodeDecoders prototype test * Fix UIntBuffer * Fix hard-coded Element identifier in CSDiag * Fix up more tests * Account for flatMap changes
* [stdlib] Add Sequence.Element, change ExpressibleByArrayLiteral.Element to ArrayLiteralElement (#8990) * Give Sequence a top-level Element, constrain Iterator to match * Remove many instances of Iterator. * Fixed various hard-coded tests * XFAIL a few tests that need further investigation * Change assoc type for arrayLiteralConvertible * Mop up remaining "better expressed as a where clause" warnings * Fix UnicodeDecoders prototype test * Fix UIntBuffer * Fix hard-coded Element identifier in CSDiag * Fix up more tests * Account for flatMap changes * Un-XFAIL crashers that don't crash on the 4.0 branch
This change will allow generic algorithms to refer to
Sequence.Element
instead ofSequence.Iterator.Element
.The PR is big but the vast bulk of the changes are removal of
Iterator.
from numerous lines.Here is some code that will break if we constrain
Sequence.Element == Iterator.Element
:This PR is changes
ExpressibleByArrayLiteral.Element
toArrayLiteralElement
. It appears no projects in the combat test suite rely on this (would only be observable if you conformed toExpressibleByArrayLiteral.Element
but notSequence
).