Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][stdlib] Add Sequence.Element #9589

Merged

Conversation

airspeedswift
Copy link
Member

And change ExpressibleByArrayLiteral.Element to ArrayLiteralElement (#8990)

4.0 merge of #8990

…nt to ArrayLiteralElement (apple#8990)

* Give Sequence a top-level Element, constrain Iterator to match

* Remove many instances of Iterator.

* Fixed various hard-coded tests

* XFAIL a few tests that need further investigation

* Change assoc type for arrayLiteralConvertible

* Mop up remaining "better expressed as a where clause" warnings

* Fix UnicodeDecoders prototype test

* Fix UIntBuffer

* Fix hard-coded Element identifier in CSDiag

* Fix up more tests

* Account for flatMap changes
@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Collaborator

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - cbce3f8
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

Huh. Looks like the regressed crashers that needed to be XFAIL'd on master don't crash on the 4.0 branch. Which is... good, I guess?

cc @DougGregor

@swift-ci
Copy link
Collaborator

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - cbce3f8
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci please test macOS platform

Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@airspeedswift airspeedswift merged commit bc558c1 into apple:swift-4.0-branch May 16, 2017
@airspeedswift airspeedswift deleted the 4.0-sequence-element branch May 16, 2017 02:49
@norio-nomura
Copy link
Contributor

This changes introduced breaking changes to https://github.com/drmohundro/SWXMLHash/ :
failed log

SWXMLHash.XMLIndexer:72:22: error: invalid redeclaration of 'Element'
    public typealias Element = (SWXMLHash.XMLIndexer)
                     ^
/home/travis/build/jpsim/SourceKitten/.build/checkouts/SWXMLHash.git-4935070468589473534/Source/SWXMLHash.swift:457:10: note: 'Element' previously declared here
    case Element(XMLElement)

This error can not be avoided even by using -swift-version 3.

@norio-nomura
Copy link
Contributor

filed SR-4951

jpsim added a commit to jpsim/whats-new-in-swift-4 that referenced this pull request May 26, 2017
'Sequence' has an 'Element' typealias as of apple/swift#9589,
which was first included in a Swift 4 snapshot on 2017-05-15-a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants