Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_fields are required whereas get_results is overidden #12

Closed
stephane opened this issue Nov 9, 2012 · 1 comment
Closed

search_fields are required whereas get_results is overidden #12

stephane opened this issue Nov 9, 2012 · 1 comment

Comments

@stephane
Copy link
Contributor

stephane commented Nov 9, 2012

When I provide my own get_results method to my field, the search_fields arguments still required.

A test could be added to know if get_results has been overridden and in this case, search_results will be ignored.

PS: I think prepare_qs_params called by default get_results is the only function to use search_fields attribute.

@applegrew
Copy link
Owner

@stephane
Please check the latest code in master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants