Make alembicassembly sample compiles again #2418
Conversation
| .insert("type", "text") | ||
| .insert("use", "required")); | ||
|
|
||
| metadata.push_back( |
There was a problem hiding this comment.
Are these supposed to be the metadata for the pinhole camera?
There was a problem hiding this comment.
No, those are assembly parameters use to sample the given alembic file.
For now, if not setted, it use 0.0f.
IIRC there is no way to retrieve the shutter open/close of the current scene, so you need to pass it explicitly to each assembly.
Doc here
The camera doesn't have shutter open/close but explicit time_offset
Any suggestion ?
There was a problem hiding this comment.
IIRC there is no way to retrieve the shutter open/close of the current scene, so you need to pass it explicitly to each assembly.
You can retrieve the shutter times of the camera. In do_expand_contents() you've got a Project so you first need to retrieve the active camera used for rendering:
const Camera* camera = project.get_scene()->get_active_camera();
Then you can use camera->get_shutter_open_begin_time(), etc. to retrieve shutter times.
I have a board I try to keep up to date. For now I will focus on implicit instancing. I will need to have a dedicated method (maybe static) for polymesh extraction because it's a big part of the code and it make the rest of the logic (specially, the code flow for instancing) hard to read. I will try to do hte PR in two times. Split polymesh extraction method, and add implicit instancing. Have you any feature you would want to see supported ? |
|
Yes we can. The next PR would be the implicit instancing system. |
I've updated the alembic assembly sample to make it compile again with new inheritance.
Any feedback appreciate. :)