Updates #103
Merged
Updates #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2017
jdent02
force-pushed
the
master
branch
2 times, most recently
from
a0ffeb4
to
3899043
Compare
dictoon
reviewed
Dec 8, 2017
project_file_writer.py
Outdated
| @@ -1340,6 +1354,55 @@ def __emit_diffuse_btdf(self, material, bsdf_name, scene, layer=None, node=None) | |||
| self.__emit_parameter("transmittance_multiplier", transmittance) | |||
| self.__close_element("bsdf") | |||
|
|
|||
| #------------------------ | |||
| #Write Sheen BRDF | |||
properties/materials.py
Outdated
| max=1.0, | ||
| update=refresh_preview) | ||
|
|
||
| sheen_reflectance_use_tex = bpy.props.BoolProperty(name="", description="Use a texture to influence sheen reflectance", default=False, |
There was a problem hiding this comment.
Let's put one parameter per line (everywhere in this file)?
properties/materials.py
Outdated
| @@ -811,9 +854,36 @@ class AppleseedMatLayerProps(bpy.types.PropertyGroup): | |||
| description="Specular BTDF transmittance multiplier", default=1.0, min=0.0, max=1.0, | |||
| update=refresh_preview) | |||
|
|
|||
| spec_fresnel_multiplier = bpy.props.FloatProperty(name="Fresnel Multiplier", | |||
| description="Fresnel multiplier", | |||
ui/materials.py
Outdated
| @@ -1116,9 +1166,29 @@ def draw(self, context): | |||
|
|
|||
| layout.prop(current_layer, "spec_btdf_trans_mult") | |||
|
|
|||
| # fresnel multiplier | |||
There was a problem hiding this comment.
fresnel -> Fresnel (https://en.wikipedia.org/wiki/Augustin-Jean_Fresnel)
|
I fixed the areas you specifically mentioned. As far as the 'one parameter per line' that's going to be a major project as there are hundreds of parameters that will need to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional controls to Specular BTDF
Add Sheen BRDF
Redo material name display