Updates #313
Updates #313
Conversation
|
Typo in commit: "Fixes for area lamos" |
path_util.py
Outdated
| # | ||
| # This software is released under the MIT license. | ||
| # | ||
| # Copyright (c) 2014-2018 Jonathan Dent, The appleseedhq Organization |
There was a problem hiding this comment.
New files should mention 2018 only.
| tmp = set(shader_directories) | ||
| shader_directories = list(tmp) | ||
|
|
||
| return shader_directories |
There was a problem hiding this comment.
Make sure all files end with a carriage return.
| items=[('debug', "Debug", ""), | ||
| ('warning', "Warning", ""), | ||
| ('error', "Error", ""), | ||
| ('critical', "Critical", "")], |
There was a problem hiding this comment.
Are these meant to be appleseed log levels? Or blenderseed ones?
| @@ -223,6 +223,14 @@ class AppleseedRenderSettings(bpy.types.PropertyGroup): | |||
| min=1, | |||
| max=max_threads) | |||
|
|
|||
| log_level = bpy.props.EnumProperty(name="log_level", | |||
There was a problem hiding this comment.
Feel free to ignore my question if it sounds stupid, but why do we deal with log levels in two different classes?
There was a problem hiding this comment.
One is the python logger for the addon itself, the other is for appleseed logger
render/__init__.py
Outdated
| @@ -51,8 +51,14 @@ def run(self): | |||
|
|
|||
|
|
|||
| class SetAppleseedLogLevel(object): | |||
| mapping = {'error': asr.LogMessageCategory.Error, | |||
There was a problem hiding this comment.
Order them by ascending severity: debug, info, warning, error, fatal.
properties/scene.py
Outdated
| @@ -223,6 +223,14 @@ class AppleseedRenderSettings(bpy.types.PropertyGroup): | |||
| min=1, | |||
| max=max_threads) | |||
|
|
|||
| log_level = bpy.props.EnumProperty(name="log_level", | |||
| items=[('error', "Errors", ""), | |||
There was a problem hiding this comment.
Order them by ascending severity: debug, info, warning, error, fatal.
No description provided.