Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #645

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Update README.md #645

merged 2 commits into from
Dec 6, 2022

Conversation

kelindi
Copy link
Contributor

@kelindi kelindi commented Dec 2, 2022

Made export LIBRARY_PATH=/opt/homebrew/lib as a code snippet for better visibility.

@kelindi
Update README.md
f591fc6 
Made export LIBRARY_PATH=/opt/homebrew/lib as a code snippet for better visibility.
@kelindi kelindi requested a review from gmelodie December 2, 2022 19:55
@en0ma
Copy link
Contributor

en0ma commented Dec 2, 2022

Made export LIBRARY_PATH=/opt/homebrew/lib as a code snippet for better visibility.

can you also update the readme to say estuary supports only golang 1.18 now

cc: @alvin-reyes

@en0ma
Copy link
Contributor

en0ma commented Dec 2, 2022

also, @kelindi is this related to #454

@kelindi
Copy link
Contributor Author

kelindi commented Dec 5, 2022

@en0ma added the go requirement. It's not related to #454 directly. I just added it in to make it visually more clear that you have to add /opt/homebrew/lib to path, when just skimming the docs.

@anjor anjor merged commit 02b4346 into dev Dec 6, 2022
@en0ma en0ma deleted the kelindi-patch-1 branch December 11, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en0ma en0ma en0ma approved these changes

@gmelodie gmelodie Awaiting requested review from gmelodie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelindi @en0ma @anjor