Refactor: break up replication into smaller modules #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/v1/handlers.go # api/v1/pinning.go # api/v2/api.go # content/pinning.go # content/staging.go # main.go
# Conflicts: # api/v1/handlers.go # api/v1/pinning.go # content/content.go # content/gc.go # content/offloading.go # content/pinning.go # content/queue/queue.go # content/replication.go # content/retrieval.go # content/staging.go # shuttle/rpc/rpc.go
# Conflicts: # main.go
# Conflicts: # api/v1/handlers.go # api/v1/pinning.go # content/pinning.go # content/replication.go # main.go # pinner/pinning.go # shuttle/rpc/rpc.go
en0ma
changed the title
en0ma
requested review from
alvin-reyes,
neelvirdy and
10d9e
and removed request for
alvin-reyes
gmelodie
reviewed
Jan 26, 2023
en0ma
force-pushed
the
refactor/break-up-replication-into-smaller-modules
branch
from
9f15134
to
39a274f
Compare
|
i tried to go through it as much as i was able to, but it's too difficult to properly review a PR of this size. The high level thought process and structure makes sense. |
…te and state for aggregate children
alvin-reyes
reviewed
Jan 30, 2023
alvin-reyes
reviewed
Jan 30, 2023
alvin-reyes
reviewed
Jan 30, 2023
alvin-reyes
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
A few minor comments but everything looks good to me.
i tested the following and it work as expected
- pinning
- content
- collections
Thank you @en0ma. We should target to deploy this as soon as the other reviews are done.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the flow from content upload to deal-making. It decomposes the replication logic into separate smaller modules that can all work in an isolated manner making them non-blocking and overall, the platform becomes more stable.
This also brings the added advantages of non-delayed deal-making as the deal queue is now persistent, with no need to rebuild it whenever the API is restarted.
Verifications