Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sp locator task #907

Merged
merged 18 commits into from
Feb 2, 2023
Merged

Feat: sp locator task #907

merged 18 commits into from
Feb 2, 2023

Conversation

jcace
Copy link
Contributor

@jcace jcace commented Jan 30, 2023

closes #679 , adding a scheduled task to run the PeerPingManager and wire up to the Estuary API, retrieving SP list to ping.

In addition, the following refactors were performed:

@jcace jcace changed the title sp locator task Feat: sp locator task Jan 30, 2023
@jcace jcace added this to the Improved SP Selection Mechanism milestone Jan 30, 2023
@jcace jcace self-assigned this Jan 30, 2023
@jcace
Copy link
Contributor Author

jcace commented Jan 30, 2023

Currently blocked from testing by #905 , will test and finish up once that is resolved.

@en0ma
Copy link
Contributor

en0ma commented Jan 31, 2023

@jcace is this still in draft or you want us to review as is?

@jcace
Copy link
Contributor Author

jcace commented Feb 1, 2023

@en0ma not done yet, soon!

@jcace
Copy link
Contributor Author

jcace commented Feb 2, 2023

Here's an example response from the new Shuttle /storage-provider/list endpoint:

[
	{
		"address": "f010617",
		"latency": 33
	},
	{
		"address": "f0135078",
		"latency": 38
	},
	{
		"address": "f01886797",
		"latency": 42
	},
	{
		"address": "f08399",
		"latency": 43
	},
	{
		"address": "f058369",
		"latency": 68
	},
	{
		"address": "f09848",
		"latency": 72
	},
	{
		"address": "f02401",
		"latency": 94
	},
	{
		"address": "f022163",
		"latency": 202
	}
]

Screenshot 2023-02-01 at 8 26 19 PM

@jcace jcace marked this pull request as ready for review February 2, 2023 03:26
@jcace jcace requested a review from neelvirdy February 2, 2023 03:26
cmd/estuary-shuttle/main.go Outdated Show resolved Hide resolved
@10d9e 10d9e self-requested a review February 2, 2023 15:00
10d9e
10d9e previously approved these changes Feb 2, 2023
Copy link
Contributor

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jcace

@en0ma en0ma dismissed 10d9e’s stale review February 2, 2023 15:04

To be safe, I am dismissing this as this comment needs to be addressed or it will break prod if deployed #907 (comment)

Copy link
Contributor

@en0ma en0ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcace jcace merged commit 36b8972 into dev Feb 2, 2023
@jcace jcace deleted the feat/sp-locator-task branch February 2, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create sp-locator scheduled task to run on shuttles
3 participants