-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: sp locator task #907
Conversation
Currently blocked from testing by #905 , will test and finish up once that is resolved. |
@jcace is this still in draft or you want us to review as is? |
dfe07f9
to
4e3dcf6
Compare
@en0ma not done yet, soon! |
Here's an example response from the new Shuttle [
{
"address": "f010617",
"latency": 33
},
{
"address": "f0135078",
"latency": 38
},
{
"address": "f01886797",
"latency": 42
},
{
"address": "f08399",
"latency": 43
},
{
"address": "f058369",
"latency": 68
},
{
"address": "f09848",
"latency": 72
},
{
"address": "f02401",
"latency": 94
},
{
"address": "f022163",
"latency": 202
}
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jcace
To be safe, I am dismissing this as this comment needs to be addressed or it will break prod if deployed #907 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #679 , adding a scheduled task to run the PeerPingManager and wire up to the Estuary API, retrieving SP list to ping.
In addition, the following refactors were performed:
/storage-providers/
endpoint, fixing nil bug and make it use gothreads (was missed in fix: sp info endpoint - chain info always null #908 )ToMultiAddress
andToMultiAddresses
functions out ofnode.go
and intoutils
, as they're being used in multiple placesShuttleHttpClient
, reducing duplicationdeal/check.go/checkContentDeals
, was missed in Refactor: break up replication into smaller modules #897