Add support for the Charts API #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akahn
reviewed
Aug 2, 2018
charts.go
Outdated
| Metric string `json:"metric,omitempty"` | ||
| Composite string `json:"composite,omitempty"` | ||
| Type string `json:"type,omitempty"` | ||
| Tags []Tag `json:"tags,omitempty"` |
There was a problem hiding this comment.
Can you also add fields here to set:
- summary_function
- group_by_function
- group_by
and the like?
akahn
reviewed
Aug 2, 2018
charts.go
Outdated
| Max float64 `json:"max,omitempty"` | ||
| Label string `json:"label,omitempty"` | ||
| RelatedSpace int `json:"related_space,omitempty"` | ||
| Threshold Threshold `json:"threshold,omitempty"` |
There was a problem hiding this comment.
We will also need transform_function here, among others.
|
Doh -- thanks for the reminder, @akahn. I picked this work up from where I'd left it a couple months ago and must've just assumed the struct was complete. I'll update. |
akahn
reviewed
Aug 2, 2018
charts.go
Outdated
| GroupFunction *string `json:"group_function,omitempty"` // valid: average, sum, min, max | ||
| GroupBy *string `json:"group_by,omitempty"` | ||
| SummaryFunction *string `json:"summary_function,omitempty"` // valid: average, sum, min, max, count | ||
| DownsampleFunction *string `json:"downsample_function,omitempty"` // valid: average, min, max, sum, cound |
akahn
reviewed
Aug 2, 2018
| TransformFunction *string `json:"transform_function,omitempty"` | ||
| Period *int `json:"period,omitempty"` | ||
| Min *int `json:"min,omitempty"` | ||
| Max *int `json:"max,omitempty"` |
There was a problem hiding this comment.
I think one field is still missing here: name:
A display name to use for the stream when generating the tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
What
Support the Charts API as defined in the docs
Why
Working toward full coverage of the REST API in this client