Feature/ts 168/integration tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS-168 * Also fix some issues with RequiredParameters
akahn
approved these changes
Apr 3, 2019
_live-tests/main_test.go
Outdated
|
|
||
| client = appoptics.NewClient(token) | ||
| // Uncomment the below to see response status/body stdout while tests run | ||
| //client = appoptics.NewClient(token, appoptics.SetDebugMode()) |
There was a problem hiding this comment.
Maybe this should be configurable via ENV, and be enabled for CI? Or is that too verbose?
There was a problem hiding this comment.
Yeah I think that's a little too verbose -- it dumps entire request bodies for each request, which can make it hard to read. I'd vote against making it the default, but I'm not against an available ENV setting for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds live tests for:
Why
So that we're regression testing the client against the production service.