Allow pipeline to be used for review app resizing

apppackio · Jun 27, 2022 · ea58cab · ea58cab
1 parent a0b5a45
commit ea58cab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/app/app.go b/app/app.go
@@ -870,11 +870,12 @@ func (a *App) SetScaleParameter(processType string, minProcessCount, maxProcessC
 	var parameterName string
 	if a.IsReviewApp() {
 		parameterName = fmt.Sprintf("/apppack/pipelines/%s/review-apps/pr/%s/scaling", a.Name, *a.ReviewApp)
-	} else if a.Pipeline {
-		return fmt.Errorf("scaling/resizing is not supported directly on pipelines")
 	} else {
 		parameterName = fmt.Sprintf("/apppack/apps/%s/scaling", a.Name)
 	}
+	if a.Pipeline && *maxProcessCount != *minProcessCount {
+		return fmt.Errorf("auto-scaling is not supported on pipelines")
+	}
 	parameterOutput, err := ssmSvc.GetParameter(&ssm.GetParameterInput{
 		Name: &parameterName,
 	})

diff --git a/cmd/ps.go b/cmd/ps.go
@@ -170,7 +170,11 @@ var psResizeCmd = &cobra.Command{
 		checkErr(a.ValidateECSTaskSize(*size))
 		err = a.ResizeProcess(processType, size.CPU, size.Memory)
 		checkErr(err)
-		printSuccess(fmt.Sprintf("resizing %s", processType))
+		if a.Pipeline {
+			printSuccess(fmt.Sprintf("set default size for %s processes on review apps", processType))
+		} else {
+			printSuccess(fmt.Sprintf("resizing %s", processType))
+		}
 	},
 }