Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency empty #100

Closed
objarni opened this issue Nov 21, 2021 · 4 comments
Closed

Missing dependency empty #100

objarni opened this issue Nov 21, 2021 · 4 comments

Comments

@objarni
Copy link
Contributor

objarni commented Nov 21, 2021

Get error when using latest released approvaltests.python version, guessing empty_files module is a new dependency not included in requirements.txt?

    import empty_files
ModuleNotFoundError: No module named 'empty_files'
greenape added a commit to Flowminder/FlowKit that referenced this issue Nov 22, 2021
@claremacrae
Copy link
Contributor

See also #102

@objarni
Copy link
Contributor Author

objarni commented Nov 25, 2021

To avoid this kind of issue resurfacing, maybe an automated "install and run a hello world approval test" integration test could be formulated with GitHub actions? Would love to see how such a thing could be formulated 🎉

@objarni
Copy link
Contributor Author

objarni commented Dec 9, 2021

I've observed some 'smoke test issues' w.r.t ApprovalTests.Python lately, this issue being one of them.

And I had a little spare time to hack around for fun! So I put together a script to test whether a "hello world" test works with a specific version of the library.

approvaltests-python-smoketest repo

@isidore
Copy link
Member

isidore commented Feb 6, 2022

Thank you for the suggestion @objarni ! We've added some automation to test the current release before and after each mob to prevent this happening in the future

@isidore isidore closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants