Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add empty-files install dependency #100 #101

Closed
wants to merge 1 commit into from

Conversation

ahitrin
Copy link
Contributor

@ahitrin ahitrin commented Nov 23, 2021

Description

Add missing installation dependency empty-files.

The solution

In version 3.0.0, a new dependency was added into requirements.txt and was used in utils.py. But it was not listed as installation dependency. This leads to runtime error.

We add this dependency to setup.py providing it being installed along with approvaltests.

Notation

I prefer lots of very small commits prefixed with Arlo's git notation

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 23, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 99.00 🙂 100.00 🙂 1.00 👎
Working memory 17.00 ⛔ 17.00 ⛔ 0.00
Quality 58.16% 🙂 58.02% 🙂 -0.14% 👎
Other metrics Before After Change
Lines 41 41 0
Changed files Quality Before Quality After Quality Change
setup.py 58.16% 🙂 58.02% 🙂 -0.14% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ahitrin ahitrin closed this Nov 23, 2021
@ahitrin
Copy link
Contributor Author

ahitrin commented Nov 23, 2021

Wrong author credentials, sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant