Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting version in publish #105

Closed
wants to merge 1 commit into from
Closed

Conversation

aaltat
Copy link
Contributor

@aaltat aaltat commented Nov 26, 2021

Fixes #103

@FredrikWendt
Copy link
Contributor

It would be nice to catch a simple error like this with a post-packaging test step/stage, that tries to import the package and does something simple.

@ghost
Copy link

ghost commented Dec 21, 2021

This is already fixed in ce1d587 Can be closed.

@isidore
Copy link
Member

isidore commented Jan 9, 2022

Already made change, but thank you for the pull request

@isidore isidore closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running Approval tests, there is NameError: name 'version_number' is not defined
3 participants