-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some refactors we did to make the linter agree with us more (Sourcery refactored) #111
Conversation
Co-Authored-By: Austin Abro <AustinAbro321> Co-Authored-By: Gregor Riegler <gregorriegler> Co-Authored-By: <chbndrhnns> Co-Authored-By: Bernhard Raml <SwamyDev>
Co-Authored-By: Austin Abro <AustinAbro321> Co-Authored-By: Gregor Riegler <gregorriegler> Co-Authored-By: <chbndrhnns> Co-Authored-By: Bernhard Raml <SwamyDev>
Co-Authored-By: Austin Abro <AustinAbro321> Co-Authored-By: Gregor Riegler <gregorriegler> Co-Authored-By: <chbndrhnns> Co-Authored-By: Bernhard Raml <SwamyDev>
…class Co-Authored-By: Austin Abro <AustinAbro321> Co-Authored-By: Gregor Riegler <gregorriegler> Co-Authored-By: <chbndrhnns> Co-Authored-By: Bernhard Raml <SwamyDev>
Co-Authored-By: Austin Abro <AustinAbro321> Co-Authored-By: Gregor Riegler <gregorriegler> Co-Authored-By: <chbndrhnns> Co-Authored-By: Bernhard Raml <SwamyDev>
extension_with_dot = "." + extension_with_dot | ||
extension_with_dot = f".{extension_with_dot}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function FileOptions.with_extension
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
if self.has_scrubber(): | ||
return self.fields["scrubber_func"](data) | ||
return data | ||
return self.fields["scrubber_func"](data) if self.has_scrubber() else data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Options.scrub
refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else
) - Replace if statement with if expression (
assign-if-exp
)
def get_class_name_for_frame(stacktrace: FrameInfo) -> str: | ||
if "self" not in stacktrace[0].f_locals: | ||
name = os.path.splitext(os.path.basename(stacktrace[1]))[0] | ||
else: | ||
name = f"{stacktrace[0].f_locals['self'].__class__.__name__}" | ||
return name | ||
return ( | ||
os.path.splitext(os.path.basename(stacktrace[1]))[0] | ||
if "self" not in stacktrace[0].f_locals | ||
else f"{stacktrace[0].f_locals['self'].__class__.__name__}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StackFrameNamer.get_class_name_for_frame
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
) - Replace if statement with if expression (
assign-if-exp
)
def get_test_frame(self, caller: List[FrameInfo]) -> int: | ||
tmp_array = [] | ||
for index, frame in enumerate(caller): | ||
if self.is_test_method(frame): | ||
tmp_array.append(index) | ||
if tmp_array: | ||
if tmp_array := [ | ||
index | ||
for index, frame in enumerate(caller) | ||
if self.is_test_method(frame) | ||
]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StackFrameNamer.get_test_frame
refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression
) - Convert for loop into list comprehension (
list-comprehension
)
def get_file_name(self) -> str: | ||
class_name = "" if (self.class_name is None) else (self.class_name + ".") | ||
class_name = "" if self.class_name is None else f'{self.class_name}.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StackFrameNamer.get_file_name
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.64%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #110 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!