Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for azure #68

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@nightfury1204
Copy link
Member

commented Feb 28, 2018

No description provided.

@nightfury1204 nightfury1204 requested a review from tamalsaha Feb 28, 2018

@nightfury1204 nightfury1204 force-pushed the azure-test branch from dd6ddfb to ac2aff2 Feb 28, 2018

@@ -203,3 +203,30 @@ func New(clientID, clientSecret, tenantName string) (*UserInfo, error) {

return u, nil
}

func NewUserInfo(clientID, clientSecret, tenantName, loginUrl, apiUrl string) (*UserInfo, error) {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Mar 6, 2018

Member

If this is only used in test, then this should also be in _test.

return nil
}

func TestCheckAzure(t *testing.T) {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Mar 6, 2018

Member

Same comment as github pr

@tamalsaha tamalsaha force-pushed the azure-test branch from 251fa38 to 646521e Mar 7, 2018

@tamalsaha tamalsaha merged commit 570529b into master Mar 7, 2018

@tamalsaha tamalsaha deleted the azure-test branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.