Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing require_level in Juniper #771

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix missing require_level in Juniper #771

merged 1 commit into from
Nov 30, 2020

Conversation

OmarIthawi
Copy link

@OmarIthawi OmarIthawi commented Nov 27, 2020

edX refactored it into HasAccessRule.

edX refactored it into HasAccessRule
@OmarIthawi OmarIthawi changed the title (wip) fix cert failures Fix missing require_level in Juniper Nov 27, 2020
@OmarIthawi OmarIthawi marked this pull request as ready for review November 27, 2020 11:45
def test_allow_beta(self, mock_get_user):
""" Test allow beta ag
mock_get_user.return_value = userainst list beta. """
def test_allow_beta(self, _mock_get_user):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just clean up for merge leftovers

@@ -3948,7 +3948,6 @@ def test_skip_entrance_exam_student(self):


@patch('bulk_email.models.html_to_text', Mock(return_value='Mocking CourseEmail.text_message', autospec=True))
@override_settings(DEFAULT_SITE_THEME='edx-theme-codebase')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

unique_id_for_user,
is_email_retired
is_email_retired,
unique_id_for_user
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match upstream

@OmarIthawi OmarIthawi merged commit 58a8c21 into main Nov 30, 2020
@OmarIthawi OmarIthawi deleted the omar/certfixes branch November 30, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants