Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAU Pipeline, models, and updated views #134

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

johnbaldwin
Copy link
Contributor

@johnbaldwin johnbaldwin commented Nov 16, 2019

Details:

  • Updated methods for figures.sites and figures.mau
  • Renamed MAU live data viewset to have 'Live' in the name
  • Added models to store MAU site and course metrics
  • Created Celery tasks to store MAU metrics
  • Added viewsets for MAU stored data
  • Added tests, Tests, TESTS!

Closes #135

@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #134 into master will decrease coverage by 0.02%.
The diff coverage is 95.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   95.28%   95.26%   -0.03%     
==========================================
  Files          30       31       +1     
  Lines        1358     1498     +140     
==========================================
+ Hits         1294     1427     +133     
- Misses         64       71       +7
Impacted Files Coverage Δ
figures/urls.py 100% <100%> (ø) ⬆️
figures/migrations/0009_mau_metrics.py 100% <100%> (ø)
figures/serializers.py 96.69% <100%> (+0.15%) ⬆️
figures/mau.py 100% <100%> (ø) ⬆️
figures/filters.py 98.66% <100%> (+0.2%) ⬆️
figures/sites.py 96.2% <88.88%> (-0.99%) ⬇️
figures/tasks.py 81.08% <90%> (+1.39%) ⬆️
figures/views.py 91.24% <94.28%> (-0.47%) ⬇️
figures/models.py 96.87% <94.33%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c3e27...2c84410. Read the comment docs.

@johnbaldwin
Copy link
Contributor Author

@melvinsoft Production code should be all here. I'm now just working on improving test coverage.

Updated methods for figures.sites and figures.mau
Renamed MAU live data viewset to have 'Live' in the name
Added models to store MAU site and course metrics
Created Celery tasks to store MAU metrics
Added viewsets for MAU stored data
Added tests, Tests, TESTS!
Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnbaldwin.

As discussed in DMs, we're skipping the code review and going directly to staging testing.

@johnbaldwin johnbaldwin merged commit 575af45 into master Nov 20, 2019
@johnbaldwin johnbaldwin deleted the john/mau-pipeline branch November 20, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants