Add the presence of the client file to diagnose #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2023
unflxw
approved these changes
May 9, 2023
| @@ -157,6 +156,9 @@ export class DiagnoseTool { | |||
| log_dir_path: { | |||
| path: logFilePath ? path.dirname(logFilePath) : "" | |||
| }, | |||
| "appsignal.cjs": { | |||
| path: this.#config.clientFilePath || "" | |||
There was a problem hiding this comment.
Here we could put the content of the file as well (see appsignal.log below) but we're not doing that because (as you said in this comment) we're going to try to get the config values in this file to be reported in the same way as the other config value sources, yes? Just checking to make sure I understood the comment and the plan.
There was a problem hiding this comment.
Yep! As we can't control what and how users write their appsignal.cjs code, I think it's more effective doing it by loading the code and then checking the config object.
tombruijn
approved these changes
May 10, 2023
luismiramirez
force-pushed
the
check-client-diagnose
branch
from
40777a6
to
2686595
Compare
The diagnose report now checks on the presence of the `appsignal.cjs` file we require customers to initialize the AppSignal client when starting their apps.
luismiramirez
force-pushed
the
check-client-diagnose
branch
from
2686595
to
71e076d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnose report now checks on the presence of the
appsignal.cjsfile we require customers to initialize the AppSignal client when starting their apps.Part of: #882