Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal logger #34

Closed
4 of 5 tasks
Tracked by #14
tombruijn opened this issue May 3, 2023 · 0 comments · Fixed by #56
Closed
4 of 5 tasks
Tracked by #14

Add internal logger #34

tombruijn opened this issue May 3, 2023 · 0 comments · Fixed by #56
Assignees
@tombruijn
Labels
enhancement

Comments

@tombruijn
Copy link
Member

tombruijn commented May 3, 2023 •
edited

To do

  • Add log option. Possible values: file (default) and stdout
  • Add integrations logger for the package. Support:
    • STDOUT logger, optional: can be separate issue
    • File logger (default)
  • Add log messages in places it makes sense
@tombruijn tombruijn mentioned this issue May 3, 2023
Closed
29 tasks
tombruijn added a commit that referenced this issue May 3, 2023
@tombruijn
Add log_path config option
28ebe4d 
Check if the specified path is writable or not, and if not, fall back on
the system tmp dir.

It just prints the warning and doesn't log it. We don't have an internal
logger yet, see issue #34. It will also need to log it eventually.

While discussing this implementation, we decided we want to refactor
this so there's a Config class that handles all the function calls, so
that we don't need to call `validate` manually this way in the future.
See issue #36. So I'm leaving a proper validation "state" in the Config
for that issue.

[skip changeset]
Part of #16
@tombruijn tombruijn mentioned this issue May 3, 2023
Merged
tombruijn added a commit that referenced this issue May 3, 2023
@tombruijn
Add log_path config option
693aae2 
Check if the specified path is writable or not, and if not, fall back on
the system tmp dir.

It just prints the warning and doesn't log it. We don't have an internal
logger yet, see issue #34. It will also need to log it eventually.

While discussing this implementation, we decided we want to refactor
this so there's a Config class that handles all the function calls, so
that we don't need to call `validate` manually this way in the future.
See issue #36. So I'm leaving a proper validation "state" in the Config
for that issue.

[skip changeset]
Part of #16
tombruijn added a commit that referenced this issue May 3, 2023
@tombruijn
Add log_path config option
366d648 
Check if the specified path is writable or not, and if not, fall back on
the system tmp dir.

It just prints the warning and doesn't log it. We don't have an internal
logger yet, see issue #34. It will also need to log it eventually.

While discussing this implementation, we decided we want to refactor
this so there's a Config class that handles all the function calls, so
that we don't need to call `validate` manually this way in the future.
See issue #36. So I'm leaving a proper validation "state" in the Config
for that issue.

[skip changeset]
Part of #16
tombruijn added a commit that referenced this issue May 3, 2023
@tombruijn
Add log_path config option
f55d22f 
Check if the specified path is writable or not, and if not, fall back on
the system tmp dir.

It just prints the warning and doesn't log it. We don't have an internal
logger yet, see issue #34. It will also need to log it eventually.

While discussing this implementation, we decided we want to refactor
this so there's a Config class that handles all the function calls, so
that we don't need to call `validate` manually this way in the future.
See issue #36. So I'm leaving a proper validation "state" in the Config
for that issue.

[skip changeset]
Part of #16
@tombruijn tombruijn mentioned this issue May 3, 2023
Closed
31 tasks
@tombruijn tombruijn self-assigned this May 9, 2023
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add internal logger
59baa31 
Allow us to log things to the appsignal.log file.
Add a new "appsignal" logger in Python and configure it to match our
logging standard.
https://github.com/appsignal/integration-guide/blob/e0faa6a9e02265b375a449ec6b0f234ccc68834a/build/logging.md

There is no "trace" level in Python. Not sure how we can support that.

This doesn't implement the STDOUT logger. That's the next step.

Part of #34
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add internal logger
c83b3a7 
Allow us to log things to the appsignal.log file.
Add a new "appsignal" logger in Python and configure it to match our
logging standard.
https://github.com/appsignal/integration-guide/blob/e0faa6a9e02265b375a449ec6b0f234ccc68834a/build/logging.md

Use the tmp_path helper argument in pytest to create a temporary path to
store the log file in for testing.

There is no "trace" level in Python. Not sure how we can support that.

This doesn't implement the STDOUT logger. That's the next step.

Part of #34
@tombruijn tombruijn mentioned this issue May 12, 2023
Merged
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add stdout logger
d18b14c 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add stdout logger
e0077ae 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add stdout logger
7888d83 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
@tombruijn tombruijn mentioned this issue May 12, 2023
Merged
tombruijn added a commit that referenced this issue May 12, 2023
@tombruijn
Add stdout logger
7d4bd4f 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
tombruijn added a commit that referenced this issue May 17, 2023
@tombruijn
Add internal logger
c7639e5 
Allow us to log things to the appsignal.log file.
Add a new "appsignal" logger in Python and configure it to match our
logging standard.
https://github.com/appsignal/integration-guide/blob/e0faa6a9e02265b375a449ec6b0f234ccc68834a/build/logging.md

Use the tmp_path helper argument in pytest to create a temporary path to
store the log file in for testing.

There is no "trace" level in Python. Not sure how we can support that.

This doesn't implement the STDOUT logger. That's the next step.

Part of #34
tombruijn added a commit that referenced this issue May 17, 2023
@tombruijn
Add stdout logger
2098664 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
tombruijn added a commit that referenced this issue May 17, 2023
@tombruijn
Add stdout logger (#51)
f72cc46 
Add stdout logger for when the configuration includes `log="stdout"`,
or when no file logger can be initialized.

[skip changeset]
Part of #34
tombruijn added a commit that referenced this issue May 17, 2023
@tombruijn
Add logging for internals
2b351ad 
Track if AppSignal is starting and if the OpenTelemetry instrumentations
are added.

[skip changeset]
Closes #34
@tombruijn tombruijn mentioned this issue May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logging for internals appsignal/appsignal-python
1 participant
@tombruijn