Add log_path config option #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
log_path-option
branch
2 times, most recently
from
4b3693c
to
7035e48
Compare
29 tasks
luismiramirez
approved these changes
May 3, 2023
unflxw
approved these changes
May 3, 2023
Check if the specified path is writable or not, and if not, fall back on the system tmp dir. It just prints the warning and doesn't log it. We don't have an internal logger yet, see issue #34. It will also need to log it eventually. While discussing this implementation, we decided we want to refactor this so there's a Config class that handles all the function calls, so that we don't need to call `validate` manually this way in the future. See issue #36. So I'm leaving a proper validation "state" in the Config for that issue. [skip changeset] Part of #16
Use the `gettempdir` method to fetch the system tmp dir. This won't work on macOS the way we want to, because it will create a new tmp dir every time and we want it to point to `/tmp`.
Make sure we always write the appsignal.log filename. There could be a scenario that if someone specified a filename like `test.log` in the `log_path` option, it would turn out something like: `/path/to/test.logappsignal.log`. Update code to use path.join, rather than my own string join solution. Probably works better cross platform.
unflxw
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add log_path config option
Check if the specified path is writable or not, and if not, fall back on the system tmp dir.
It just prints the warning and doesn't log it. We don't have an internal logger yet, see issue #34. It will also need to log it eventually.
While discussing this implementation, we decided we want to refactor this so there's a Config class that handles all the function calls, so that we don't need to call
validatemanually this way in the future. See issue #36. So I'm leaving a proper validation "state" in the Config for that issue.[skip changeset] Part of #16
Fetch tmp dir in a cross platform way
Use the
gettempdirmethod to fetch the system tmp dir. This won't work on macOS the way we want to, because it will create a new tmp dir every time and we want it to point to/tmp.