Add extensions definition to gemspec #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
git-source-installation
branch
from
b863ab4
to
1296ebb
Compare
jvanbaarsen
approved these changes
Jan 16, 2019
This fixes the issue that the AppSignal gem doesn't install through Bundler when specifying a git source: ``` gem "appsignal", :git => "https://github.com/appsignal/appsignal-ruby.git", :branch => "master" ``` This change adds the `extensions` config option as described here: https://guides.rubygems.org/specification-reference/#extensions by default for the Ruby C-extension. This means it does not work for JRuby when installing through a git source. This was broken in #377 where we generate the gemspecs for Ruby and JRuby during the "rake publish" process. We only ask users to use the git source when testing something small. So full support for all implementations (JRuby) doesn't seem necessary at this time. We don't recommend users to rely on the git source installation method all the time.
tombruijn
force-pushed
the
git-source-installation
branch
from
e3ff49b
to
ae09a5f
Compare
|
Something broke with another gem release. Moved back to WIP so I can fix it.. |
jeffkreeftmeijer
approved these changes
Jan 21, 2019
|
Merging. The failed jobs are fixed in #459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that the AppSignal gem doesn't install through
Bundler when specifying a git source:
This change adds the
extensionsconfig option as described here:https://guides.rubygems.org/specification-reference/#extensions
by default for the Ruby C-extension. This means it does not work for
JRuby when installing through a git source.
This was broken in #377 where we generate the gemspecs for Ruby and
JRuby during the "rake publish" process.
We only ask users to use the git source when testing something small. So
full support for all implementations (JRuby) doesn't seem necessary at
this time. We don't recommend users to rely on the git source
installation method all the time.