Fix error in AS when transaction get completed #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an AppSignal transaction is closed in an instrumentation block (which
shouldn't happen), the transaction can no longer be called to finish an
event.
```
ActiveSupport::Notifications.instrument("foo") do
Appsignal::Transaction.complete_current!
end
```
To fix the error that would occur, fetch the transaction again from
`Appsignal::Transaction.current` instead of using the `transaction`
variable that was available. If the transaction was closed inside the
instrumentation block, it will return a `NilTransaction` which will
ignore the method call instead of raising an error.
tombruijn
requested review from
thijsc,
jeffkreeftmeijer,
jvanbaarsen and
matsimitsu
matsimitsu
approved these changes
Jun 3, 2019
jvanbaarsen
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an AppSignal transaction is closed in an instrumentation block (which
shouldn't happen), the transaction can no longer be called to finish an
event.
To fix the error that would occur, fetch the transaction again from
Appsignal::Transaction.currentinstead of using thetransactionvariable that was available. If the transaction was closed inside the
instrumentation block, it will return a
NilTransactionwhich willignore the method call instead of raising an error.