Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]-[77]:Dissalowed Value DD.MM.YYYY in the Display Date Format Property of a Column in the Table Widget #18572

Closed
1 task done
ame-appsmith opened this issue Nov 30, 2022 · 11 comments · Fixed by #28784
Closed
1 task done
Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Table Widget V2 Issues related to Table Widget V2 Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@ame-appsmith
Copy link

ame-appsmith commented Nov 30, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

A user is trying to use DD.MM.YYYY in the Display Date Format property of a table column, but it returns an error: Dissalowed value.
image

https://community.appsmith.com/t/cannot-set-dd-mm-yyyy-date-format-for-table-column/1694

Steps To Reproduce

  1. Add a Table widget to the canvas and bind it to some data (e.g., the users sample database).
  2. Try to change the format of a date column to DD.MM.YYYY in the Display Date Format property.

Public Sample App

No response

Issue video log

No response

Version

Appsmith v1.8.10-SNAPSHOT

Front logo Front conversations

@ame-appsmith ame-appsmith added Bug Something isn't working Table Widget Needs Triaging Needs attention from maintainers to triage Table Widget V2 Issues related to Table Widget V2 labels Nov 30, 2022
@ame-appsmith ame-appsmith changed the title [Bug]: [Bug]: Dissalowed Value: DD.MM.YYYY in the Display Date Format Property of a Column in the Table Widget Nov 30, 2022
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Nov 30, 2022
@dilippitchika
Copy link
Contributor

Assuming 10% of date users face this

Stats

Stat Values
Reach 77
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Dissalowed Value: DD.MM.YYYY in the Display Date Format Property of a Column in the Table Widget [Bug]-[77]:Dissalowed Value Dec 21, 2022
@dilippitchika dilippitchika changed the title [Bug]-[77]:Dissalowed Value [Bug]-[77]:Dissalowed Value DD.MM.YYYY in the Display Date Format Property of a Column in the Table Widget Dec 21, 2022
@dilippitchika
Copy link
Contributor

@vsvamsi1 please check this as well

@sbalaji1192 sbalaji1192 removed their assignment Mar 10, 2023
@vsvamsi1
Copy link
Contributor

@dilippitchika These are the formats we can support
"YYYY-MM-DDTHH:mm:ss.SSSZ", "Epoch", "Milliseconds", "YYYY-MM-DD", "YYYY-MM-DD HH:mm", "YYYY-MM-DDTHH:mm:ss.sssZ", "YYYY-MM-DDTHH:mm:ss", "YYYY-MM-DD hh:mm:ss", "Do MMM YYYY", "DD/MM/YYYY", "DD/MM/YYYY HH:mm", "LLL", "LL", "D MMMM, YYYY", "H:mm A D MMMM, YYYY", "MM-DD-YYYY", "DD-MM-YYYY", "MM/DD/YYYY", "DD/MM/YYYY", "DD/MM/YY", "MM/DD/YY",
can the user use either of thse format
"DD/MM/YY","DD-MM-YYYY",

@dilippitchika
Copy link
Contributor

@vsvamsi1 the same dd.mm.yyyy works in the datepicker widget but not here in the table, is there a reason?

@vsvamsi1
Copy link
Contributor

Hi @dilippitchika, Its very strange on the DatePicker there are no restrictions on the allowed in the formats. You could enter a random incorrect format like in the screenshot and there is no error from our app. For the datePicker it attempts to format what it can infer, whereas in the Table we limit it to a list. Im not sure what is the right behaviour.
Screenshot 2023-03-21 at 11.03.38 AM.png

@dilippitchika
Copy link
Contributor

If we are the ones limiting to a list in datepickers inside tables, why can't we add DD.MM.YYYY? Regardind datepicker widget not validating, please create a separate issue

@vsvamsi1
Copy link
Contributor

vsvamsi1 commented Mar 24, 2023

Sure @dilippitchika will do that and these new formats we should support for Display date format and not Original Date format?

@dilippitchika
Copy link
Contributor

We should support it for both i believe, display and original date

@ame-appsmith
Copy link
Author

We have another user on Discord who is trying to set the date format programmatically. The formats are supported in a Date Picker widget, but not in the Table Date column.
Here are some examples of date formats that are disallowed in the Table column but supported in the Date Picker widget:

  • DD/MM/YYYY hh:mm:ss A
  • DD.MM.YYYY HH:mm:ss A
  • MM/DD/YYYY hh:mm:ss A

@ame-appsmith
Copy link
Author

Another user raised the same issue on Discord.

@vsvamsi1 vsvamsi1 removed their assignment Nov 9, 2023
@Nikhil-Nandagopal
Copy link
Contributor

@ame-appsmith a workaround for this is to update the computed value and format it using moment

somangshu pushed a commit that referenced this issue Nov 20, 2023
#28784)

#### PR fixes following issue(s)
Fixes #18572
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 20, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Table Widget V2 Issues related to Table Widget V2 Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants