Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The response pane should always be visible regardless of the eval state of the JsObject. #33884

Closed
parth-appsmith opened this issue May 31, 2024 · 0 comments · Fixed by #33990
Closed

The response pane should always be visible regardless of the eval state of the JsObject. #33884

parth-appsmith opened this issue May 31, 2024 · 0 comments · Fixed by #33990
Assignees
@ayushpahwa
Labels
High This issue blocks a user from building or impacts a lot of users Task A simple Todo Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Milestone
WF-27May-7June

Comments

@parth-appsmith
Copy link

Ideal behaviour

Regardless of the eval state of the JsObject the response pane should always be visible with all its details.

Current state

If you’re editing the JsObject with the response pane open as you’re writing code the response pane switches between disabled and active state based on the evaluation of the code. This causes constant flickering and the response is required to be visible to be able to write code while debugging.

Private Zenhub Video
@parth-appsmith parth-appsmith added the Workflows Pod Issues that the workflows team owns label May 31, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 31, 2024
@parth-appsmith parth-appsmith added the High This issue blocks a user from building or impacts a lot of users label May 31, 2024
@github-actions github-actions bot removed the Workflows Pod Issues that the workflows team owns label May 31, 2024
@parth-appsmith parth-appsmith added Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product labels Jun 3, 2024
@ayushpahwa ayushpahwa added this to the WF-27May-7June milestone Jun 5, 2024
@ayushpahwa ayushpahwa mentioned this issue Jun 5, 2024
Merged
2 tasks
ayushpahwa added a commit that referenced this issue Jun 5, 2024
@ayushpahwa
feat: remove disable overlay for incorrect js objects (#33990)
6ebb017 
## Description
When the js functions fail to parse (eg. incomplete quotes etc), the
jsresponse view is disabled with an overlay. Now since remote js run
component stays as a child of the jsresponse view component and
shouldn't be hidden even if the js is malformed. Refer to the issue
linked for more info.

NOTE: Since this PR is only touching EE functionality, the output for CE
is not changed. The tests present today shall cover this. The tests for
the new experience will be added in the EE PR.

Fixes #33884 

## Automation

/ok-to-test tags="@tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9381657328>
> Commit: 65afce9
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9381657328&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved error message and log information display based on execution
permissions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushpahwa ayushpahwa

Labels
High This issue blocks a user from building or impacts a lot of users Task A simple Todo Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Milestone
WF-27May-7June
Development

Successfully merging a pull request may close this issue.

feat: remove disable overlay for incorrect js objects appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @ayushpahwa @parth-appsmith