New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Helm configMap to update application configuration #10157
feat: Add Helm configMap to update application configuration #10157
Conversation
@geekup-legodevops is attempting to deploy a commit to the Appsmith Team on Vercel. A member of the Team first needs to authorize it. |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better, thanks guys. Just a couple of minor questions, otherwise we are ready to merge this in!
echo 'Load environment configuration' | ||
set -o allexport | ||
. "$ENV_PATH" | ||
. "$TEMPLATES_PATH/pre-define.env" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all,
seems to me, this line, does not work as expcected on our kubernetes 1.21 environment.
only default-env-vars from $ENV_PATH are actually used within the script, following "pre-define.env"-files are not picked up, even though the file exists and contains values (e.g. for mongo-db).
See attached screenshot, where I entered some debugging points to point out env-variables while running entrypoint.sh:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharat87 could you have a look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, while I'm not sure of this without looking at the entrypoint_wdr.sh
script, I think you are dealing with the issue fixed in this PR: #11799. We should be publishing it soon.
As a workaround in the meantime, could you try adding a backslash just before the ?
and see if that makes a difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharat87 Thank you for pointing out #11799 to me. Actually escaping Question-Marks (?) and Ampersands (&) with a backslash (or in my case double back-slash to get it through our own scripting-pipeline) worked for me. Looking forward to the PR to be released, as other special-chars might be problematic as well (as described in the PR)
Thank you
Description
Type of change
Checklist: