fix: Fix special char handling in pre-define env

[sharat87]

When starting the fat container with APPSMITH_MONGODB_URI variable set to a value that has query params, like mongodb+srv://user:pass@appsmith.abcde.mongodb.net/testdb?retryWrites=true&w=majority, then the fat container ignores it and goes ahead with using a local MongoDB server.

The problem is that we generated a pre-define.env file, that gets the following line (among many others like it):

APPSMITH_MONGODB_URI=mongodb+srv://user:pass@appsmith.abcde.mongodb.net/testdb?retryWrites=true&w=majority

This file is then sourced with . pre-define.env. When this runs, this file is evaluated like a shell script, and the shell's glob based file-name expansions take affect.

So for this line, the shell looks for a file that looks like mongodb+srv://user:pass@appsmith.abcde.mongodb.net/testdb?retryWrites=true&w=majority, where there's any letter in place of the ?, which is the glob definition of ? character. Since it doesn't find any such files, it will turn this line into just APPSMITH_MONGODB_URI=, indicating that there's no files to expand the glob pattern into.

Now since the APPSMITH_MONGODB_URI is set to empty value, the fat container will proceed to use it's local MongoDB just fine.

This can be avoided by wrapping the value in quotes. Like

APPSMITH_MONGODB_URI='mongodb+srv://user:pass@appsmith.abcde.mongodb.net/testdb?retryWrites=true&w=majority'

In this case, the shell will take the value verbatim and won't attempt to do glob expansion (or any potential variable expansion, if the value has any $ characters in it).

This PR adds a sed transformation to the generation of pre-define.env that:

1. Replaces ' in each line with '"'"', which is kind of an escaped single-quote, in a single-quoted string.
2. Adds a ' just after the = sign on each line.
3. Adds a ' at the end of each line.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

> export z="a'b=d?x"
> printenv | sed "s/'/'\"'\"'/; s/=/='/; s/$/'/" | grep '^z'
z='a'"'"'b=d?x'

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/BLm8Lt1dUakypPTxHLB4EEnGWRYn
✅ Preview: https://appsmith-git-sharat87-patch-1-get-appsmith.vercel.app

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[WernerEngelsB]

even though this PR is referened in Changelog of v1.6.15, the actual entrypoint.sh within v1.6.15 (https://github.com/appsmithorg/appsmith/blob/v1.6.15/deploy/docker/entrypoint.sh) does not seem to have the changes of this PR merged...

[WernerEngelsB]

even though this PR is referened in Changelog of v1.6.15, the actual entrypoint.sh within v1.6.15 (https://github.com/appsmithorg/appsmith/blob/v1.6.15/deploy/docker/entrypoint.sh) does not seem to have the changes of this PR merged...

@sharat87 could you have a look, why this happend?

[sharat87]

Hey @WernerDreierB, thanks for bringing my attention to this. This fix wasn't part of the last release, it was erroneously reported in the release notes. We are correcting the release notes now. Thanks!