Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App crashes when a modal has a filepicker? (#10376) #10380

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented Jan 13, 2022

(cherry picked from commit f646eea)

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: cp/fix-file-picker 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.06 (0.04) 36.56 (0.01) 34.49 (-0.03) 55.57 (0.06)
🟢 app/client/src/api/PluginApi.ts 89.47 (3.76) 100 (0) 60 (10) 88.89 (3.89)
🔴 app/client/src/components/formControls/DropDownControl.tsx 44.44 (-0.39) 2.17 (0.04) 16.67 (-3.33) 42.86 (0)
🔴 app/client/src/pages/Editor/GeneratePage/components/GeneratePageForm/GeneratePageForm.tsx 18.18 (-0.24) 10.47 (-0.06) 0 (0) 20.29 (-0.3)
🟢 app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx 37.5 (1.56) 29.59 (0.69) 0 (0) 39 (1.68)
🟢 app/client/src/sagas/FormEvaluationSaga.ts 40 (15.68) 27.27 (12.27) 50 (25) 47.06 (18.03)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)
🟢 app/client/src/widgets/CheckboxGroupWidget/component/index.tsx 25 (-4.03) 12.5 (6.94) 0 (0) 33.33 (-2.67)
🟢 app/client/src/widgets/CheckboxGroupWidget/widget/index.tsx 58.73 (7.38) 29.17 (2.25) 44.44 (6.34) 59.32 (7.15)
🔴 app/client/src/widgets/CheckboxWidget/component/index.tsx 96.55 (-0.42) 64 (-3.74) 90 (-0.91) 95.83 (-0.32)
🟢 app/client/src/widgets/TabsWidget/component/index.tsx 100 (10.89) 83.33 (18.33) 100 (18.18) 100 (9.3)
🔴 app/client/src/widgets/TabsWidget/widget/index.tsx 77.42 (-1.15) 47.14 (0) 78.95 (0) 77.27 (-0.51)
🟢 app/client/src/workers/formEval.ts 14.29 (0.4) 3.13 (0.31) 10 (0) 14.29 (0.4)
app/client/src/widgets/CheckboxGroupWidget/constants.ts 100 100 100 100
app/client/src/widgets/TabsWidget/constants.ts 100 100 100 100

@vercel
Copy link

vercel bot commented Jan 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/D7f1J2swRLc6DYv3ng9waHgcBAka
✅ Preview: https://appsmith-git-cp-fix-file-picker-get-appsmith.vercel.app

@jsartisan jsartisan changed the base branch from release to master January 13, 2022 08:25
@github-actions github-actions bot added the Bug Something isn't working label Jan 13, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@mohanarpit mohanarpit merged commit 3172b3e into master Jan 13, 2022
@mohanarpit mohanarpit deleted the cp/fix-file-picker branch January 13, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants